Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust tax conv. criterion and activate it #1556

Merged
merged 3 commits into from
Feb 16, 2024
Merged

adjust tax conv. criterion and activate it #1556

merged 3 commits into from
Feb 16, 2024

Conversation

LaviniaBaumstark
Copy link
Member

@LaviniaBaumstark LaviniaBaumstark commented Feb 16, 2024 •
edited
Loading

Purpose of this PR

adjust and activate tax criterion as Nash convergance criterion

Type of change

  • Minor change (default scenarios show only small differences)

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

  • Test runs are here:
  • Comparison of results (what changes by this PR?):

@mleimbach
Copy link
Contributor

Shouldn't the comment in line 974 be changed to "... convergence check is on" ?

@mleimbach
Copy link
Contributor

Did we decided for 10% tolerance? That`s certainly too much. If this should be a real check, 1% or even less should be applied.

@LaviniaBaumstark LaviniaBaumstark merged commit 7085fc0 into remindmodel:develop Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mleimbach mleimbach mleimbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LaviniaBaumstark @mleimbach